Fix white space around top and bottom edges of extra long images #6384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@tgolen Gentle reminder. Looks like the workflow requires an approval to proceed as this is my first PR here. |
tgolen
approved these changes
Nov 30, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
95 tasks
|
🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes an issue where a white empty space was shown at the top and bottom of extra long images.
There was a 1px border around the thumbnail image which was not taken into account while calculating the image dimensions. This resulted in the rendered image from getting squished due to box-sizing. To fix this thumbnail styles are now applied to a parent View which wraps the fixed width container that embeds the image.
Fixed Issues
$ #5162
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android